ci(docs-truth): fail fast on unusable org read token - #55
Merged
Conversation
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
peycheff-com
approved these changes
Jul 23, 2026
Fail before checkout when MINDBURN_ORG_READ_TOKEN is empty or cannot read the subject, inventory, ledger, or pinned runner repositories. This covers the public-subject/private-dependency failure mode observed in the fleet probe and makes token entitlement errors explicit. Signed-off-by: mindburnlabs <mindburnlabs@gmail.com>
peycheff-com
force-pushed
the
claude/docs-truth-token-guard
branch
from
July 29, 2026 13:31
1e426b7 to
3cdbe92
Compare
peycheff-com
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an explicit pre-check to the public reusable Docs Truth workflow for
MINDBURN_ORG_READ_TOKEN.Before any checkout, the workflow now verifies that the token:
.githubinventory repository;docsledger repository; anddev-orchestrationrunner repository.The check reports the exact repository and HTTP status when entitlement is missing.
Why
workflow_call.secrets.required: truevalidates only that callers declare the key. It does not prove that a value reaches the run or that the token can read every repository used by the workflow.The July fleet probe exposed both failure modes:
Checkout subject repo;Checkout docs truth ledger.Checking only the subject would therefore produce a false green preflight for public subjects. This PR probes the complete checkout read-set and turns misleading
actions/checkoutfailures into an entitlement-specific error.Validation
actionlint .github/workflows/docs-truth-public.ymlgit diff --checkmain: all nine selected callers now complete Docs Truth successfully withMINDBURN_ORG_READ_TOKEN.Refs HELM-311 and HELM-41.